merge config prop passed to BentoProvider with the one passed at creation #999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veej
changed the title
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
packages/bento-design-system/test/createBentoProvider.test.tsx:5
- [nitpick] Consider renaming the test suite from 'createBentoProviders' to 'createBentoProvider' to match the actual function name and avoid potential confusion.
describe("createBentoProviders", () => {
pedrodim
reviewed
Apr 7, 2025
| <DefaultMessagesContext.Provider value={{ defaultMessages }}> | ||
| <BentoConfigProvider value={props.config ?? config}> | ||
| <DefaultMessagesContext.Provider value={defaultMessagesValue}> | ||
| <BentoConfigProvider value={deepmerge(config, props.config) as BentoConfig}> |
There was a problem hiding this comment.
I don't know how much overhead deepmerge adds when one object is undefined, but since BentoConfigProvider internally does a deepmerge too, maybe we can do the merge only if there's a props.config?
Suggested change
| <BentoConfigProvider value={deepmerge(config, props.config) as BentoConfig}> | |
| <BentoConfigProvider value={props.config ? deepmerge(config, props.config) as BentoConfig : config}> |
pedrodim
approved these changes
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.